kubevirt / containerized-data-importer / #5837

49%

main: 49%

Build Type

Pull #4046

travis-ci

Committed by akalenyu

Commit Message

Use an uncached client for webhooks, cache only PVs with transform

Using a cached client for webhooks was never a great idea, with stale
entries being somewhat dangerous or plain and simply blocking. For
example:

  #!/bin/bash
  kubectl create -f source-pvc.yaml
  kubectl wait --for=condition=Bound pvc/source-pvc --timeout=60s
  # clone target PVC goes through the mutating webhook which needs
  # to read the source PVC and StorageProfile to render defaults;
  # a stale cache may not see them yet, resulting in a rejection.
  kubectl create -f clone-target-pvc.yaml

The cost of using an uncached client is low, since the only verb we
act on is CREATE.

PersistentVolumes are the exception — they can be numerous with large
specs, and renderPvcSpecFromAvailablePv relies on a field index that
requires a cache. A dedicated PV-only cache with a transform function
is used to keep only the fields needed by the webhook (StorageClassName,
Capacity, AccessModes, VolumeMode, Phase).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

Pull Request Pull Request #4046: Use an uncached client for webhooks, cache only PVs with transform

Run Details

3 of 64 new or added lines in 4 files covered. (4.69%)

3 existing lines in 2 files now uncovered.

14715 of 29795 relevant lines covered (49.39%)

0.55 hits per line