Idrinth / habit-evaluator / 22360481384

40%

push

github

Fix habit completion buttons having no effect on Android HomeScreen (#621)

The Complete and Remove Completion buttons on the HomeScreen silently
failed because the inline coroutine handlers called RoomHabitRepository
methods (which use runBlocking internally) from within a coroutine
context, with no error handling. Any exception killed the coroutine
silently, and loadHabits() was only called at the end so the UI never
refreshed.

- Move completion logic to AppViewModel.completeHabit() and
  removeHabitCompletion() using viewModelScope with try-finally to
  always refresh the habit list
- Add loadHabitsSync() helper for synchronous habit list refresh
- Fix EntityMappers.toModel() to restore ScoringRule from stored
  scoringRuleId/scoringRuleName (was silently lost on every load-save
  cycle)
- Add regression tests for ScoringRule restoration and round-trip

https://claude.ai/code/session_01WrtANRsn9pVnot8MUXeroa

Co-authored-by: Claude <noreply@anthropic.com>

2944 of 7823 branches covered (37.63%)

Branch coverage included in aggregate %.

10369 of 25179 relevant lines covered (41.18%)

2.11 hits per line