Qiskit / qiskit / 22353739383

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Upgrade to PyO3 0.28 (#15670)

The major change for us is that `pyclass` on `Clone` types no longer
automatically derives a cloning implementation of `FromPyObject`.  We
now have to opt-in to having it with an extra derive.  Here I've tried
to avoid opting in, except in cases where the underlying `struct` is
small and `Copy`; this turned up a few places where we've been lazy with
/ missed `extract` calls that could just be `cast`s.  I left one place
(in `ConsolidateBlocks`) where we _shouldn't_ need to clone out of
Python space, but it would be rather involved to refactor the logic to
make this work better, since we're unfortunately using the
Python-exposed function as the main driver logic, rather than the
Rust-native help function that lives next to it.

On the `rust-numpy` side, a change intended to fix a bug in implicit
dimension handling in `PyArrayLike` had a knock-on effect of making
allocating type conversions fail.  Every current usage within Qiskit
_wants_ the automatic conversion by nature of using `PyArrayLike` as an
extraction point and not a cast, so we have to change our usage sites to
allow the conversion now.

Run Details

117 of 188 new or added lines in 36 files covered. (62.23%)

26 existing lines in 9 files now uncovered.

100279 of 114173 relevant lines covered (87.83%)

1150510.32 hits per line