kubeovn / kube-ovn / 22339974249

23%

master: 23%

Build Type

Pull #6328

github

Committed by oilbeater

Commit Message

refactor(controller): reduce duplication and complexity in pod.go

Extract shared utility functions and split oversized functions to
improve readability and maintainability without changing behavior.

Phase 1 - Extract utility functions:
- checkStatefulSetPodStatus: unify isStatefulSetPodToDel/isStatefulSetPodToGC
- movePortToPortGroup: deduplicate 3 port group move operations
- acquireRandomAddressWithValidation: deduplicate 2 random IP loops
- subnetHasAvailableIPs: simplify switch/fallthrough logic
- podAllocatedChanged: deduplicate NP/ANP allocated checks
- Reuse existing getIPSuffix from subnet.go

Phase 2 - Split long functions:
- reconcileRouteSubnets (275→~50 lines): extract handleOverlaySubnetRoute,
  handleEipSnatRoute, handleEipSnatNatRules
- handleDeletePod (230→~80 lines): extract cleanupPodPolicyRoutesAndNAT,
  cleanupPodIPCRs
- getPodAttachmentNet (185→~50 lines): extract resolveDeletedNADSubnet,
  resolveOVNAttachmentNet, buildOVNProviderName, findSubnetByProvider
- acquireAddress: extract resolveMAC

Phase 3 - Minor cleanups:
- Extract enqueuePodDeletion helper
- Remove unused pod parameter from handleEipSnatRoute

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

Pull Request Pull Request #6328: refactor(controller): reduce duplication and complexity in pod.go

Run Details

49 of 413 new or added lines in 1 file covered. (11.86%)

17 existing lines in 1 file now uncovered.

12554 of 54305 relevant lines covered (23.12%)

0.27 hits per line