FlexMeasures / flexmeasures / 22305931956

78%

main: 78%

Build Type

push

github

Committed by web-flow

Commit Message

Update timing defaults in forecasting schema (#1974)

* feat: make predict retrain-frequency default to planning horizon then min(planning_horizon, data["max_forecast_horizon"])

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* refactor:  simplify end_date calculation to use predict_period instead of timedelta

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: default max_forecast_horizon to predict_period

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: add validation for max_forecast_horizon to ensure it does not exceed predict_period

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: set default forecast_frequency based on min of planning_horizon, predict_period, and max_forecast_horizon

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* fix: add planning horizon from config

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* dev: uncomment out tests that were failing

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* fix: fix test cae forecast_frequency expectation it should be 12 hours not 48hours since we want New forecast viewpoint every 12 hours

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* fix: tests should expect 5 cycles. the test passes when we expect 1cycle

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: add duration to schema

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: pass original data to `resolve_config` so we can check whether start, end and duration have been passed

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: move end_date calculation up

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* feat: fix max-forecast-horizon and forecast freq default calculation

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* dev: remove breakpoint

Sig... (continued)

Run Details

1629 of 2158 branches covered (75.49%)

Branch coverage included in aggregate %.

89 of 93 new or added lines in 4 files covered. (95.7%)

8 existing lines in 2 files now uncovered.

11227 of 14368 relevant lines covered (78.14%)

4.69 hits per line