22285099215

Committed 22 Feb 2026 08:52PM UTC coverage: 75.854% (-17.1%) from 92.936%

Build # 22285099215

Build Type

Pull #23121

github

Committed by

web-flow

Commit Message

Merge c7299df9c into ba8359840

Pull Request Pull Request #23121: fix issue with optional fields in dependency validator

Run Details

28 of 29 new or added lines in 2 files covered. (96.55%)

11174 existing lines in 400 files now uncovered.

53694 of 70786 relevant lines covered (75.85%)

1.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/src/python/pants/util/requirements.py

# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).
from collections.abc import Iterator

from pants.util.pip_requirement import PipRequirement


def parse_requirements_file(content: str, *, rel_path: str) -> Iterator[PipRequirement]:
    """Parse all `PipRequirement` objects from a requirements.txt-style file.

    This will safely ignore any options starting with `--` and will ignore comments. Any pip-style
    VCS requirements will fail, with a helpful error message describing how to use PEP 440.
    """
    for i, line in enumerate(content.splitlines(), start=1):
        line, _, _ = line.partition("--")
        line = line.strip().rstrip("\\")
        if not line or line.startswith(("#", "-")):
            continue

        # Strip comments which are otherwise on a valid requirement line.
        comment_pos = line.find("#")
        if comment_pos != -1:
            line = line[0:comment_pos].strip()

        yield PipRequirement.parse(line, description_of_origin=f"{rel_path} at line {i}")

1	# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3	from collections.abc import Iterator	4✔
4
5	from pants.util.pip_requirement import PipRequirement	4✔
6
7
8	def parse_requirements_file(content: str, *, rel_path: str) -> Iterator[PipRequirement]:	4✔
9	"""Parse all `PipRequirement` objects from a requirements.txt-style file.
10
11	This will safely ignore any options starting with `--` and will ignore comments. Any pip-style
12	VCS requirements will fail, with a helpful error message describing how to use PEP 440.
13	"""
14	for i, line in enumerate(content.splitlines(), start=1):	2✔
15	line, _, _ = line.partition("--")	1✔
16	line = line.strip().rstrip("\\")	1✔
17	if not line or line.startswith(("#", "-")):	1✔
UNCOV 18	continue	×
19
20	# Strip comments which are otherwise on a valid requirement line.
21	comment_pos = line.find("#")	1✔
22	if comment_pos != -1:	1✔
UNCOV 23	line = line[0:comment_pos].strip()	×
24
25	yield PipRequirement.parse(line, description_of_origin=f"{rel_path} at line {i}")	1✔

pantsbuild / pants / 22285099215

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous