22285099215

Committed 22 Feb 2026 08:52PM UTC coverage: 75.854% (-17.1%) from 92.936%

Build # 22285099215

Build Type

Pull #23121

github

Committed by

web-flow

Commit Message

Merge c7299df9c into ba8359840

Pull Request Pull Request #23121: fix issue with optional fields in dependency validator

Run Details

28 of 29 new or added lines in 2 files covered. (96.55%)

11174 existing lines in 400 files now uncovered.

53694 of 70786 relevant lines covered (75.85%)

1.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.67

/src/python/pants/engine/internals/nodes.py

# Copyright 2020 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

from dataclasses import dataclass
from typing import Any


@dataclass(frozen=True)
class Return:
    """Indicates that a Node successfully returned a value."""

    value: Any


_Frame = tuple[str, str | None]


@dataclass(frozen=True)
class Throw:
    """Indicates that a Node should have been able to return a value, but failed."""

    exc: Exception
    python_traceback: str | None = None
    engine_traceback: tuple[_Frame, ...] = ()

    def _render_frame(self, frame: _Frame, include_trace_on_error: bool) -> str | None:
        """Renders either only the description (if set), or both the name and description."""
        name, desc = frame

        if include_trace_on_error:
            return f"{name}\n    {desc or '..'}"
        elif desc:
            return f"{desc}"
        else:
            return None

    def render(self, include_trace_on_error: bool) -> str:
        all_rendered_frames = [
            self._render_frame(frame, include_trace_on_error)
            for frame in reversed(self.engine_traceback)
        ]
        rendered_frames = [f for f in all_rendered_frames if f]
        engine_traceback_str = ""
        if rendered_frames:
            sep = "\n  in "
            engine_traceback_str = "Engine traceback:" + sep + sep.join(rendered_frames) + "\n\n"
        if include_trace_on_error:
            python_traceback_str = f"{self.python_traceback}" if self.python_traceback else ""
        else:
            python_traceback_str = f"{type(self.exc).__name__}: {str(self.exc)}"
        return f"{engine_traceback_str}{python_traceback_str}"

1	# Copyright 2020 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	4✔
5
6	from dataclasses import dataclass	4✔
7	from typing import Any	4✔
8
9
10	@dataclass(frozen=True)	4✔
11	class Return:	4✔
12	"""Indicates that a Node successfully returned a value."""
13
14	value: Any	4✔
15
16
17	_Frame = tuple[str, str \| None]	4✔
18
19
20	@dataclass(frozen=True)	4✔
21	class Throw:	4✔
22	"""Indicates that a Node should have been able to return a value, but failed."""
23
24	exc: Exception	4✔
25	python_traceback: str \| None = None	4✔
26	engine_traceback: tuple[_Frame, ...] = ()	4✔
27
28	def _render_frame(self, frame: _Frame, include_trace_on_error: bool) -> str \| None:	4✔
29	"""Renders either only the description (if set), or both the name and description."""
30	name, desc = frame	4✔
31
32	if include_trace_on_error:	4✔
33	return f"{name}\n {desc or '..'}"	4✔
UNCOV 34	elif desc:	×
35	return f"{desc}"	×
36	else:
UNCOV 37	return None	×
38
39	def render(self, include_trace_on_error: bool) -> str:	4✔
40	all_rendered_frames = [	4✔
41	self._render_frame(frame, include_trace_on_error)
42	for frame in reversed(self.engine_traceback)
43	]
44	rendered_frames = [f for f in all_rendered_frames if f]	4✔
45	engine_traceback_str = ""	4✔
46	if rendered_frames:	4✔
47	sep = "\n in "	4✔
48	engine_traceback_str = "Engine traceback:" + sep + sep.join(rendered_frames) + "\n\n"	4✔
49	if include_trace_on_error:	4✔
50	python_traceback_str = f"{self.python_traceback}" if self.python_traceback else ""	4✔
51	else:
UNCOV 52	python_traceback_str = f"{type(self.exc).__name__}: {str(self.exc)}"	×
53	return f"{engine_traceback_str}{python_traceback_str}"	4✔

pantsbuild / pants / 22285099215

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous