22285099215

Committed 22 Feb 2026 08:52PM UTC coverage: 75.854% (-17.1%) from 92.936%

Build # 22285099215

Build Type

Pull #23121

github

Committed by

web-flow

Commit Message

Merge c7299df9c into ba8359840

Pull Request Pull Request #23121: fix issue with optional fields in dependency validator

Run Details

28 of 29 new or added lines in 2 files covered. (96.55%)

11174 existing lines in 400 files now uncovered.

53694 of 70786 relevant lines covered (75.85%)

1.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.73

/src/python/pants/engine/internals/native_dep_inference.py

# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

from dataclasses import dataclass
from typing import AbstractSet, Sequence

from pants.util.frozendict import FrozenDict


@dataclass(frozen=True)
class NativePythonFileDependencies:
    imports: FrozenDict[str, tuple[int, bool]]
    string_candidates: FrozenDict[str, int]
    explicit_dependencies: FrozenDict[str, int]

    def __init__(
        self,
        imports: dict[str, tuple[int, bool]],
        string_candidates: dict[str, int],
        explicit_dependencies: dict[str, int],
    ):
        object.__setattr__(self, "imports", FrozenDict(imports))
        object.__setattr__(self, "string_candidates", FrozenDict(string_candidates))
        object.__setattr__(self, "explicit_dependencies", FrozenDict(explicit_dependencies))


@dataclass(frozen=True)
class NativePythonFilesDependencies:
    path_to_deps: FrozenDict[str, NativePythonFileDependencies]


@dataclass(frozen=True)
class JavascriptDependencyCandidate:
    file_imports: frozenset[str]
    package_imports: frozenset[str]

    def __init__(self, file_imports: AbstractSet[str], package_imports: AbstractSet[str]):
        object.__setattr__(self, "file_imports", frozenset(file_imports))
        object.__setattr__(self, "package_imports", frozenset(package_imports))


@dataclass(frozen=True)
class NativeJavascriptFileDependencies:
    imports: FrozenDict[str, JavascriptDependencyCandidate]

    def __init__(self, imports: dict[str, JavascriptDependencyCandidate]):
        object.__setattr__(self, "imports", FrozenDict(imports))

    @property
    def file_imports(self) -> frozenset[str]:
        return frozenset(
            string for candidate in self.imports.values() for string in candidate.file_imports
        )

    @property
    def package_imports(self) -> frozenset[str]:
        return frozenset(
            string for candidate in self.imports.values() for string in candidate.package_imports
        )


@dataclass(frozen=True)
class NativeJavascriptFilesDependencies:
    path_to_deps: FrozenDict[str, NativeJavascriptFileDependencies]


@dataclass(frozen=True)
class NativeDockerfileInfo:
    source: str
    build_args: tuple[str, ...]  # "ARG_NAME=VALUE", ...
    copy_source_paths: tuple[str, ...]
    copy_build_args: tuple[str, ...]  # "ARG_NAME=UPSTREAM_TARGET_ADDRESS", ...
    from_image_build_args: tuple[str, ...]  # "ARG_NAME=UPSTREAM_TARGET_ADDRESS", ...
    version_tags: tuple[str, ...]  # "STAGE TAG", ...

    def __init__(
        self,
        source: str,
        build_args: Sequence[str],
        copy_source_paths: Sequence[str],
        copy_build_args: Sequence[str],
        from_image_build_args: Sequence[str],
        version_tags: Sequence[str],
    ):
        object.__setattr__(self, "source", source)
        object.__setattr__(self, "build_args", tuple(build_args))
        object.__setattr__(self, "copy_source_paths", tuple(copy_source_paths))
        object.__setattr__(self, "copy_build_args", tuple(copy_build_args))
        object.__setattr__(self, "from_image_build_args", tuple(from_image_build_args))
        object.__setattr__(self, "version_tags", tuple(version_tags))


@dataclass(frozen=True)
class NativeDockerfileInfos:
    path_to_infos: FrozenDict[str, NativeDockerfileInfo]

1	# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	4✔
5
6	from dataclasses import dataclass	4✔
7	from typing import AbstractSet, Sequence	4✔
8
9	from pants.util.frozendict import FrozenDict	4✔
10
11
12	@dataclass(frozen=True)	4✔
13	class NativePythonFileDependencies:	4✔
14	imports: FrozenDict[str, tuple[int, bool]]	4✔
15	string_candidates: FrozenDict[str, int]	4✔
16	explicit_dependencies: FrozenDict[str, int]	4✔
17
18	def __init__(	4✔
19	self,
20	imports: dict[str, tuple[int, bool]],
21	string_candidates: dict[str, int],
22	explicit_dependencies: dict[str, int],
23	):
24	object.__setattr__(self, "imports", FrozenDict(imports))	4✔
25	object.__setattr__(self, "string_candidates", FrozenDict(string_candidates))	4✔
26	object.__setattr__(self, "explicit_dependencies", FrozenDict(explicit_dependencies))	4✔
27
28
29	@dataclass(frozen=True)	4✔
30	class NativePythonFilesDependencies:	4✔
31	path_to_deps: FrozenDict[str, NativePythonFileDependencies]	4✔
32
33
34	@dataclass(frozen=True)	4✔
35	class JavascriptDependencyCandidate:	4✔
36	file_imports: frozenset[str]	4✔
37	package_imports: frozenset[str]	4✔
38
39	def __init__(self, file_imports: AbstractSet[str], package_imports: AbstractSet[str]):	4✔
UNCOV 40	object.__setattr__(self, "file_imports", frozenset(file_imports))	×
UNCOV 41	object.__setattr__(self, "package_imports", frozenset(package_imports))	×
42
43
44	@dataclass(frozen=True)	4✔
45	class NativeJavascriptFileDependencies:	4✔
46	imports: FrozenDict[str, JavascriptDependencyCandidate]	4✔
47
48	def __init__(self, imports: dict[str, JavascriptDependencyCandidate]):	4✔
49	object.__setattr__(self, "imports", FrozenDict(imports))	1✔
50
51	@property	4✔
52	def file_imports(self) -> frozenset[str]:	4✔
53	return frozenset(	×
54	string for candidate in self.imports.values() for string in candidate.file_imports
55	)
56
57	@property	4✔
58	def package_imports(self) -> frozenset[str]:	4✔
59	return frozenset(	×
60	string for candidate in self.imports.values() for string in candidate.package_imports
61	)
62
63
64	@dataclass(frozen=True)	4✔
65	class NativeJavascriptFilesDependencies:	4✔
66	path_to_deps: FrozenDict[str, NativeJavascriptFileDependencies]	4✔
67
68
69	@dataclass(frozen=True)	4✔
70	class NativeDockerfileInfo:	4✔
71	source: str	4✔
72	build_args: tuple[str, ...] # "ARG_NAME=VALUE", ...	4✔
73	copy_source_paths: tuple[str, ...]	4✔
74	copy_build_args: tuple[str, ...] # "ARG_NAME=UPSTREAM_TARGET_ADDRESS", ...	4✔
75	from_image_build_args: tuple[str, ...] # "ARG_NAME=UPSTREAM_TARGET_ADDRESS", ...	4✔
76	version_tags: tuple[str, ...] # "STAGE TAG", ...	4✔
77
78	def __init__(	4✔
79	self,
80	source: str,
81	build_args: Sequence[str],
82	copy_source_paths: Sequence[str],
83	copy_build_args: Sequence[str],
84	from_image_build_args: Sequence[str],
85	version_tags: Sequence[str],
86	):
87	object.__setattr__(self, "source", source)	3✔
88	object.__setattr__(self, "build_args", tuple(build_args))	3✔
89	object.__setattr__(self, "copy_source_paths", tuple(copy_source_paths))	3✔
90	object.__setattr__(self, "copy_build_args", tuple(copy_build_args))	3✔
91	object.__setattr__(self, "from_image_build_args", tuple(from_image_build_args))	3✔
92	object.__setattr__(self, "version_tags", tuple(version_tags))	3✔
93
94
95	@dataclass(frozen=True)	4✔
96	class NativeDockerfileInfos:	4✔
97	path_to_infos: FrozenDict[str, NativeDockerfileInfo]	4✔

pantsbuild / pants / 22285099215

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous