22285099215

Committed 22 Feb 2026 08:52PM UTC coverage: 75.854% (-17.1%) from 92.936%

Build # 22285099215

Build Type

Pull #23121

github

Committed by

web-flow

Commit Message

Merge c7299df9c into ba8359840

Pull Request Pull Request #23121: fix issue with optional fields in dependency validator

Run Details

28 of 29 new or added lines in 2 files covered. (96.55%)

11174 existing lines in 400 files now uncovered.

53694 of 70786 relevant lines covered (75.85%)

1.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.21

/src/python/pants/backend/visibility/rules.py

# Copyright 2022 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).
from __future__ import annotations

from collections.abc import Iterable

from pants.backend.visibility.rule_types import BuildFileVisibilityRules
from pants.backend.visibility.subsystem import VisibilitySubsystem
from pants.engine.goal import CurrentExecutingGoals
from pants.engine.internals.build_files import get_dependencies_rule_application
from pants.engine.internals.dep_rules import (
    BuildFileDependencyRulesImplementation,
    BuildFileDependencyRulesImplementationRequest,
)
from pants.engine.rules import Rule, collect_rules, implicitly, rule
from pants.engine.target import (
    Dependencies,
    DependenciesRuleApplicationRequest,
    FieldSet,
    ValidatedDependencies,
    ValidateDependenciesRequest,
)
from pants.engine.unions import UnionRule


class BuildFileVisibilityImplementationRequest(BuildFileDependencyRulesImplementationRequest):
    pass


class VisibilityValidateFieldSet(FieldSet):
    required_fields = (Dependencies,)


class VisibilityValidateDependenciesRequest(ValidateDependenciesRequest):
    field_set_type = VisibilityValidateFieldSet


@rule
async def build_file_visibility_implementation(
    _: BuildFileVisibilityImplementationRequest,
) -> BuildFileDependencyRulesImplementation:
    return BuildFileDependencyRulesImplementation(BuildFileVisibilityRules)


@rule
async def visibility_validate_dependencies(
    request: VisibilityValidateDependenciesRequest,
    visibility: VisibilitySubsystem,
    goals: CurrentExecutingGoals,
) -> ValidatedDependencies:
    if not visibility.enforce or goals.is_running("lint"):
        return ValidatedDependencies()

    address = request.field_set.address
    dependencies_rule_action = await get_dependencies_rule_application(
        DependenciesRuleApplicationRequest(
            address=address,
            dependencies=request.dependencies,
            description_of_origin=f"get dependency rules for {address}",
        ),
        **implicitly(),
    )
    dependencies_rule_action.execute_actions()
    return ValidatedDependencies()


def rules() -> Iterable[Rule | UnionRule]:
    return (
        *collect_rules(),
        UnionRule(
            BuildFileDependencyRulesImplementationRequest,
            BuildFileVisibilityImplementationRequest,
        ),
        UnionRule(ValidateDependenciesRequest, VisibilityValidateDependenciesRequest),
    )

1	# Copyright 2022 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3	from __future__ import annotations	1✔
4
5	from collections.abc import Iterable	1✔
6
7	from pants.backend.visibility.rule_types import BuildFileVisibilityRules	1✔
8	from pants.backend.visibility.subsystem import VisibilitySubsystem	1✔
9	from pants.engine.goal import CurrentExecutingGoals	1✔
10	from pants.engine.internals.build_files import get_dependencies_rule_application	1✔
11	from pants.engine.internals.dep_rules import (	1✔
12	BuildFileDependencyRulesImplementation,
13	BuildFileDependencyRulesImplementationRequest,
14	)
15	from pants.engine.rules import Rule, collect_rules, implicitly, rule	1✔
16	from pants.engine.target import (	1✔
17	Dependencies,
18	DependenciesRuleApplicationRequest,
19	FieldSet,
20	ValidatedDependencies,
21	ValidateDependenciesRequest,
22	)
23	from pants.engine.unions import UnionRule	1✔
24
25
26	class BuildFileVisibilityImplementationRequest(BuildFileDependencyRulesImplementationRequest):	1✔
27	pass	1✔
28
29
30	class VisibilityValidateFieldSet(FieldSet):	1✔
31	required_fields = (Dependencies,)	1✔
32
33
34	class VisibilityValidateDependenciesRequest(ValidateDependenciesRequest):	1✔
35	field_set_type = VisibilityValidateFieldSet	1✔
36
37
38	@rule	1✔
39	async def build_file_visibility_implementation(	1✔
40	_: BuildFileVisibilityImplementationRequest,
41	) -> BuildFileDependencyRulesImplementation:
42	return BuildFileDependencyRulesImplementation(BuildFileVisibilityRules)	1✔
43
44
45	@rule	1✔
46	async def visibility_validate_dependencies(	1✔
47	request: VisibilityValidateDependenciesRequest,
48	visibility: VisibilitySubsystem,
49	goals: CurrentExecutingGoals,
50	) -> ValidatedDependencies:
51	if not visibility.enforce or goals.is_running("lint"):	1✔
52	return ValidatedDependencies()	1✔
53
UNCOV 54	address = request.field_set.address	×
UNCOV 55	dependencies_rule_action = await get_dependencies_rule_application(	×
56	DependenciesRuleApplicationRequest(
57	address=address,
58	dependencies=request.dependencies,
59	description_of_origin=f"get dependency rules for {address}",
60	),
61	**implicitly(),
62	)
UNCOV 63	dependencies_rule_action.execute_actions()	×
UNCOV 64	return ValidatedDependencies()	×
65
66
67	def rules() -> Iterable[Rule \| UnionRule]:	1✔
68	return (	1✔
69	*collect_rules(),
70	UnionRule(
71	BuildFileDependencyRulesImplementationRequest,
72	BuildFileVisibilityImplementationRequest,
73	),
74	UnionRule(ValidateDependenciesRequest, VisibilityValidateDependenciesRequest),
75	)

pantsbuild / pants / 22285099215

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous