22285099215

Committed 22 Feb 2026 08:52PM UTC coverage: 75.854% (-17.1%) from 92.936%

Build # 22285099215

Build Type

Pull #23121

github

Committed by

web-flow

Commit Message

Merge c7299df9c into ba8359840

Pull Request Pull Request #23121: fix issue with optional fields in dependency validator

Run Details

28 of 29 new or added lines in 2 files covered. (96.55%)

11174 existing lines in 400 files now uncovered.

53694 of 70786 relevant lines covered (75.85%)

1.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71

/src/python/pants/backend/python/macros/common_fields.py

# Copyright 2022 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

from collections.abc import Iterable
from typing import ClassVar

from pants.backend.python.target_types import (
    PythonRequirementModulesField,
    PythonRequirementTarget,
    PythonRequirementTypeStubModulesField,
    normalize_module_mapping,
)
from pants.engine.addresses import Address
from pants.engine.target import DictStringToStringSequenceField, OverridesField
from pants.util.frozendict import FrozenDict
from pants.util.strutil import help_text


class ModuleMappingField(DictStringToStringSequenceField):
    alias = "module_mapping"
    help = help_text(
        f"""
        A mapping of requirement names to a list of the modules they provide.

        For example, `{{"ansicolors": ["colors"]}}`.

        Any unspecified requirements will use a default. See the
        `{PythonRequirementModulesField.alias}` field from the `{PythonRequirementTarget.alias}`
        target for more information.
        """
    )
    value: FrozenDict[str, tuple[str, ...]]
    default: ClassVar[FrozenDict[str, tuple[str, ...]]] = FrozenDict()

    @classmethod
    def compute_value(  # type: ignore[override]
        cls, raw_value: dict[str, Iterable[str]], address: Address
    ) -> FrozenDict[str, tuple[str, ...]]:
        value_or_default = super().compute_value(raw_value, address)
        return normalize_module_mapping(value_or_default)


class TypeStubsModuleMappingField(DictStringToStringSequenceField):
    alias = "type_stubs_module_mapping"
    help = help_text(
        f"""
        A mapping of type-stub requirement names to a list of the modules they provide.

        For example, `{{"types-requests": ["requests"]}}`.

        If the requirement is not specified _and_ its name looks like a type stub, Pants will
        use a default. See the `{PythonRequirementTypeStubModulesField.alias}` field from the
        `{PythonRequirementTarget.alias}` target for more information.
        """
    )
    value: FrozenDict[str, tuple[str, ...]]
    default: ClassVar[FrozenDict[str, tuple[str, ...]]] = FrozenDict()

    @classmethod
    def compute_value(  # type: ignore[override]
        cls, raw_value: dict[str, Iterable[str]], address: Address
    ) -> FrozenDict[str, tuple[str, ...]]:
        value_or_default = super().compute_value(raw_value, address)
        return normalize_module_mapping(value_or_default)


class RequirementsOverrideField(OverridesField):
    help = help_text(
        """
        Override the field values for generated `python_requirement` targets.

        Expects a dictionary of requirements to a dictionary for the
        overrides. You may either use a string for a single requirement,
        or a string tuple for multiple requirements. Each override is a dictionary of
        field names to the overridden value.

        For example:

            overrides={
                "django": {"dependencies": ["#setuptools"]},
                "ansicolors": {"description": "pretty colors"]},
                ("ansicolors, "django"): {"tags": ["overridden"]},
            }

        Every overridden requirement is validated to be generated by this target.

        You can specify the same requirement in multiple keys, so long as you don't
        override the same field more than one time for the requirement.
        """
    )

1	# Copyright 2022 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	2✔
5
6	from collections.abc import Iterable	2✔
7	from typing import ClassVar	2✔
8
9	from pants.backend.python.target_types import (	2✔
10	PythonRequirementModulesField,
11	PythonRequirementTarget,
12	PythonRequirementTypeStubModulesField,
13	normalize_module_mapping,
14	)
15	from pants.engine.addresses import Address	2✔
16	from pants.engine.target import DictStringToStringSequenceField, OverridesField	2✔
17	from pants.util.frozendict import FrozenDict	2✔
18	from pants.util.strutil import help_text	2✔
19
20
21	class ModuleMappingField(DictStringToStringSequenceField):	2✔
22	alias = "module_mapping"	2✔
23	help = help_text(	2✔
24	f"""
25	A mapping of requirement names to a list of the modules they provide.
26
27	For example, `{{"ansicolors": ["colors"]}}`.
28
29	Any unspecified requirements will use a default. See the
30	`{PythonRequirementModulesField.alias}` field from the `{PythonRequirementTarget.alias}`
31	target for more information.
32	"""
33	)
34	value: FrozenDict[str, tuple[str, ...]]	2✔
35	default: ClassVar[FrozenDict[str, tuple[str, ...]]] = FrozenDict()	2✔
36
37	@classmethod	2✔
38	def compute_value( # type: ignore[override]	2✔
39	cls, raw_value: dict[str, Iterable[str]], address: Address
40	) -> FrozenDict[str, tuple[str, ...]]:
UNCOV 41	value_or_default = super().compute_value(raw_value, address)	×
UNCOV 42	return normalize_module_mapping(value_or_default)	×
43
44
45	class TypeStubsModuleMappingField(DictStringToStringSequenceField):	2✔
46	alias = "type_stubs_module_mapping"	2✔
47	help = help_text(	2✔
48	f"""
49	A mapping of type-stub requirement names to a list of the modules they provide.
50
51	For example, `{{"types-requests": ["requests"]}}`.
52
53	If the requirement is not specified _and_ its name looks like a type stub, Pants will
54	use a default. See the `{PythonRequirementTypeStubModulesField.alias}` field from the
55	`{PythonRequirementTarget.alias}` target for more information.
56	"""
57	)
58	value: FrozenDict[str, tuple[str, ...]]	2✔
59	default: ClassVar[FrozenDict[str, tuple[str, ...]]] = FrozenDict()	2✔
60
61	@classmethod	2✔
62	def compute_value( # type: ignore[override]	2✔
63	cls, raw_value: dict[str, Iterable[str]], address: Address
64	) -> FrozenDict[str, tuple[str, ...]]:
UNCOV 65	value_or_default = super().compute_value(raw_value, address)	×
UNCOV 66	return normalize_module_mapping(value_or_default)	×
67
68
69	class RequirementsOverrideField(OverridesField):	2✔
70	help = help_text(	2✔
71	"""
72	Override the field values for generated `python_requirement` targets.
73
74	Expects a dictionary of requirements to a dictionary for the
75	overrides. You may either use a string for a single requirement,
76	or a string tuple for multiple requirements. Each override is a dictionary of
77	field names to the overridden value.
78
79	For example:
80
81	overrides={
82	"django": {"dependencies": ["#setuptools"]},
83	"ansicolors": {"description": "pretty colors"]},
84	("ansicolors, "django"): {"tags": ["overridden"]},
85	}
86
87	Every overridden requirement is validated to be generated by this target.
88
89	You can specify the same requirement in multiple keys, so long as you don't
90	override the same field more than one time for the requirement.
91	"""
92	)

pantsbuild / pants / 22285099215

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous