moconnell / yolo / 22279386367

81%

push

github

Fix: Prevent cancellation of already-filled orders when WebSocket fill event races with tracker registration (#107)

* Initial plan

* fix: buffer early WebSocket fill events to prevent cancellation of filled orders

When a limit order fills immediately on placement, the WebSocket fill event
can arrive before AddOrderTracker registers the order in orderTrackers. This
caused the fill event to be discarded, leaving the order in 'Open' state until
the timeout monitor attempted to cancel it (failing with an error since it was
already filled).

Fix:
- Add pendingOrderUpdates dict to buffer WebSocket events for unregistered orders
- Extract HandleSingleOrderUpdate local function from the per-update loop body
- In HandleOrderStatusUpdates, buffer events for unknown orders instead of discarding
- In AddOrderTracker, replay any buffered events after registering the tracker
- After all orders placed, immediately complete the channel if orderTrackers is empty

Co-authored-by: moconnell <640958+moconnell@users.noreply.github.com>

* Changes before error encountered

Co-authored-by: moconnell <640958+moconnell@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: moconnell <640958+moconnell@users.noreply.github.com>

286 of 297 branches covered (96.3%)

Branch coverage included in aggregate %.

50 of 59 new or added lines in 1 file covered. (84.75%)

1970 of 2260 relevant lines covered (87.17%)

36.09 hits per line