22276537352
90%

Ran 22 Feb 2026 01:21PM UTC

Jobs 1

Files 92

Run time 1min

Badge

Embed ▾

Committed 22 Feb 2026 11:47AM UTC coverage: 89.959% (+0.05%) from 89.909%

Build # 22276537352

Build Type

push

github

Committed by

akorotkov

Commit Message

Fix undo stack corruption in group insert with autonomous transactions

add_new_undo_stack_item_to_process() used lockerState->localXid % PROC_XID_ARRAY_SIZE
to index into the target process's undoStackLocations array. However, localXid was
never initialized (always zero from shared memory), while GET_CUR_UNDO_STACK_LOCATIONS()
uses autonomousNestingLevel as the index. When the waiter process was inside an
autonomous transaction (autonomousNestingLevel > 0), the undo stack item was written
to slot 0 instead of the correct slot, corrupting the non-autonomous undo stack.

This led to a rare assertion failure in set_my_reserved_location():
  Assert(!UndoLocationIsValid(GET_CUR_UNDO_STACK_LOCATIONS(undoType)->location))
The orphaned undo item in slot 0 remained after the autonomous transaction finished
and autonomousNestingLevel returned to 0, while free_retained_undo_location() had
already cleared transactionUndoRetainLocation.

Fix by replacing the uninitialized localXid field with autonomousNestingLevel in
OPageWaiterShmemState, initializing it when the process queues as a page waiter,
and passing it directly to add_new_undo_stack_item_to_process().

Coverage Stats

44645 of 49628 relevant lines covered (89.96%)

65801705.84 hits per line

Coverage Regressions

Lines	Coverage	∆	File
23	93.43	0.2%	orioledb/src/transam/undo.c
15	96.93	0.01%	orioledb/src/btree/page_state.c
4	89.64	-0.32%	orioledb/src/btree/find.c
2	86.11	0.0%	orioledb/src/btree/io.c
2	95.76	-0.22%	orioledb/src/btree/scan.c
1	71.11	0.49%	orioledb/src/btree/fastpath.c
1	84.0	-2.0%	orioledb/src/checkpoint/control.c
1	88.77	-0.12%	orioledb/src/transam/oxid.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	22276537352.1	22 Feb 2026 01:21PM UTC	92	89.96	GitHub Action Run

orioledb / orioledb / 22276537352
90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 22276537352

orioledb / orioledb / 22276537352 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 22276537352

orioledb / orioledb / 22276537352
90%

README BADGES
x