kaidokert / modmath-rs / 22271885342

99%

Build Type

push

github

Committed by web-flow

Commit Message

Consolidate strict code (#8)

* Apply bitmask optimization and Hensel canonicalization across all variants
Port strict_mont.rs improvements to basic and constrained:
- from_montgomery: use & mask instead of % r, add r_bits==0 guard
- Hensel lifting: canonicalize N' to [0, R)
- constrained mod_exp: use & one for parity, skip trailing square

* Address review feedback: fix comments, remove dead canonicalization
- r_bits==0 comment: clarify it's a fast path for R=1, not underflow avoidance
- Hensel N' canonicalization: remove dead code (n_prime is already in [0,R)
  after lifting, and % r / < zero() is unreachable for unsigned types)
* Remove stale Rem bounds from strict_from_montgomery, fix test name
- strict_from_montgomery no longer uses % or %=, drop Rem/RemAssign bounds
- Rename overflow_prevention test to large_modulus, clarify limitations
- montgomery_mul: document O(k) mod_mul defeating performance purpose
- from_montgomery: document m*N overflow risk at key sizes
- Both fixed in Phase 1 with WideningMul (see ROADMAP.md)
- Fix misleading test comment about default NPrimeMethod

Run Details

138 of 148 new or added lines in 3 files covered. (93.24%)

1 existing line in 1 file now uncovered.

3125 of 3147 relevant lines covered (99.3%)

756.57 hits per line