Alan-Jowett / ebpf-verifier / 22235569093
88%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 81
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.002% (-0.2%) from 88.157%
22235569093

push

github

web-flow 
Handle Call builtins: fix handling of Falco tests  (#1025)

* falco: fix raw_tracepoint privilege and group expected failures

Mark raw_tracepoint/raw_tracepoint_writable as privileged program types so Falco raw-tracepoint sections are not treated as unprivileged argument checks.

Update Falco sample matrix to move now-passing sections out of TEST_SECTION_FAIL and group the remaining expected failures by root-cause class (offset lower-bound loss vs size lower-bound loss at correlated joins).

Signed-off-by: Elazar Gershuni <elazarg@gmail.com>

* elf/unmarshal: gate builtin relocations via platform call model

Add platform hooks to resolve builtin symbols and provide builtin call contracts, thread relocation-gated builtin call offsets through ProgramInfo, and only treat static helper IDs as builtins at gated call sites.

Also extend platform-table, marshal, and YAML-platform tests to cover builtin resolver wiring and call unmarshal behavior.
* crab: canonicalize unsigned intervals in bitwise_and
When uvalue intervals temporarily carry signed lower bounds (e.g. after joins), Interval::bitwise_and asserted in debug builds. Canonicalize both operands via zero_extend(64) before unsigned bitwise reasoning, preserving soundness and avoiding debug aborts.

Validated by reproducing SIGABRT on reverted code in [falco][verify] and confirming the patched build completes with expected 73 pass / 20 failed-as-expected.

* Fix unsound bitwise_and case for non-singleton all-ones rhs

Signed-off-by: Elazar Gershuni <elazarg@gmail.com>

239 of 252 new or added lines in 9 files covered. (94.84%)

602 existing lines in 16 files now uncovered.

11743 of 13344 relevant lines covered (88.0%)

3262592.78 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
69.52
 0.57% src/elf_loader.cpp
2
75.4
 0.81% src/crab/interval.cpp
2
94.64
 0.86% src/ir/unmarshal.cpp
8
76.19
 -2.5% src/test/ebpf_yaml.cpp

Uncovered Existing Lines

Lines Coverage ∆ File
1
99.88
 0.11% src/test/test_verify.cpp
3
95.0
 0.36% src/crab/type_to_num.hpp
4
88.24
 1.57% src/cfg/wto.hpp
12
84.03
 6.93% src/ir/syntax.hpp
18
71.43
 -21.79% src/arith/linear_expression.hpp
18
87.43
 -1.2% src/crab/type_to_num.cpp
18
94.64
 0.86% src/ir/unmarshal.cpp
19
81.55
 7.94% src/linux/linux_platform.cpp
20
91.53
 -5.42% src/crab/ebpf_checker.cpp
31
83.64
 -8.92% src/ir/assertions.cpp
49
89.91
 -0.63% src/crab/type_domain.cpp
56
76.51
 0.0% src/result.cpp
58
76.19
 -2.5% src/test/ebpf_yaml.cpp
60
91.39
 -1.77% src/crab/ebpf_transformer.cpp
110
78.03
 6.8% src/ir/cfg_builder.cpp
125
57.85
 -0.92% src/printing.cpp
Jobs
ID Job ID Ran Files Coverage
1 run-Release - 22235569093.1 81
87.18
 GitHub Action Run
2 run-Debug - 22235569093.2 81
85.94
 GitHub Action Run
Source Files on build 22235569093