gauntface / go-html-asset-manager / 22231641949

68%

Build Type

push

github

Committed by web-flow

Commit Message

Optimize S3 requests with caching and concurrency limiting (#708)

* Optimize S3 requests by implementing caching and concurrency limiting

- Introduced a global cache and singleflight in `assets/genimgs` to ensure only one S3 lookup per image.
- Implemented a semaphore to limit concurrent S3 requests to 2 across both lookups and uploads.
- Removed redundant local caching in `opengraphimg`.
- Resolved a potential data race by returning copies of cached slices.
- Ensured no binary artifacts are included in the commit.

Co-authored-by: gauntface <139760+gauntface@users.noreply.github.com>

* Optimize S3 requests with caching, concurrency limiting, and comprehensive tests

- Implemented S3 request limiting (max 2) using semaphores in both `genimgs` cmd and `assets/genimgs` package.
- Added global per-run cache and `singleflight` deduplication for S3 image lookups.
- Refactored `LookupSizes` to use an interface for better testability.
- Added unit tests in `assets/genimgs_test.go` to verify caching and concurrency logic.
- Updated existing tests in `imgtopicture` and `opengraphimg` for compatibility.
- Fixed a data race by returning copies of cached slices.
- Removed redundant local caching.
- Cleaned up unused imports and accidental binary artifacts.

Co-authored-by: gauntface <139760+gauntface@users.noreply.github.com>

* Minor updates

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Run Details

23 of 40 new or added lines in 2 files covered. (57.5%)

1 existing line in 1 file now uncovered.

1705 of 2530 relevant lines covered (67.39%)

11.29 hits per line