Gallopsled / pwntools / 22218049498

74%

Build Type

push

github

Committed by web-flow

Commit Message

asm: try native binutils before fallback architectures (#2669)

* asm: try native binutils before fallback architectures

Some binutils builds support multiple architectures,
like the x86_64 assembler supports i386 too in most
package builds and vice versa. We support this by trying
the other binutils as well when looking for the right tool.
That support is optional though and there are packages
that don't include the "cross" compilation.

When assembling for the host's native architecture, we
still prefer the explicitly named `x86_64-linux-gnu-as`
instead of the native `as` binary. That native binary is
tried as a last resort after looking for any other explictly
named binary. If the fallback package is installed but
compiled without the cross-compiler support, we'd still
find the `i386-as` binary while looking for `x86_64-as`
before trying the native `as` binary.
That would fail to assemble.

This patch moves the native `as` binary forward in the list
to try it before checking the other fallback architecture ones.

Fixes #2509

* Update CHANGELOG

Run Details

3859 of 6510 branches covered (59.28%)

4 of 4 new or added lines in 1 file covered. (100.0%)

22 existing lines in 7 files now uncovered.

13524 of 18307 relevant lines covered (73.87%)

0.74 hits per line