mozilla-releng / balrog / #5241

90%

push

circleci

Consider required signoffs from the scheduled change instead of the rule (#3680)

When we have to signoff on a rule that changes channel, the frontend was
only considering signoff requirements from the current state of the rule
instead of considering the signoff requirements of the scheduled state.
If said old requirement was "no signoff" then no one would've been able
to signoff despite signoffs being required. This is very easily
reproduced by moving a rule from a channel that requires no signoff to a
channel that does.

We're already getting those from the backend in
`rule.scheduledChange.required_signoffs` so we can just use that
instead.

2165 of 2546 branches covered (85.04%)

Branch coverage included in aggregate %.

5730 of 6236 relevant lines covered (91.89%)

0.92 hits per line