bacnet-js / client / 22172468942

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(segmentation): correctly reassemble segmented ComplexACK responses (#71)

## Summary
This PR fixes segmented response handling for BACnet `ComplexACK`
messages.

## Problem
Some devices return segmented `ComplexACK` responses (e.g. large
object/property payloads).
The client could enter an invalid APDU state during reassembly,
resulting in abort/error behavior and missing response payload.

## Root Cause
Segment flags/state were not handled consistently across segmented
frames and final reassembled APDU processing.

## Changes
- Correct segmented `ComplexACK` reassembly flow.
- Clear segmented state/flags after full APDU is reassembled.
- Ensure final payload is passed once through normal decode path after
reassembly.

## Impact
- Stabilizes reads from devices that require segmentation.
- Prevents invalid state transitions/abort loops in segmented exchanges.
- Improves compatibility with larger BACnet payloads.

## Validation
- Verified against real-device traffic with segmented `ComplexACK`.
- Confirmed reassembled response is decoded successfully.
- Confirmed no regression for non-segmented responses.

## Compatibility
Backward compatible.  
No API changes.

Run Details

877 of 1362 branches covered (64.39%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

5166 of 5923 relevant lines covered (87.22%)

36.67 hits per line