stacklok / toolhive / 22169901697

63%

Build Type

push

github

Committed by web-flow

Commit Message

Add EmbeddingServerRef to VirtualMCPServer for optimizer integration (#3839)

* Auto-deploy EmbeddingServer with inline and reference support

Add hybrid EmbeddingServer pattern to VirtualMCPServer, enabling both
inline (1:1 auto-deployed) and reference (shared) modes. This allows
multiple VirtualMCPServers to share a single EmbeddingServer resource
via embeddingServerRef, reducing GPU/memory waste when using the same
embedding model.

Key changes:
- Add EmbeddingServerRef type and spec field (mutually exclusive with
  inline embeddingServer)
- Add webhook validation enforcing mutual exclusivity and
  optimizer/embedding co-dependency rules
- Add controller-level validation for referenced EmbeddingServer
  existence and readiness
- Add EmbeddingServer watch for reference-based reconciliation
- Add EmbeddingServerReady condition type and status reporting
- Extract runValidations helper to reduce Reconcile complexity
- Update config wiring to resolve embedding service name for both modes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* review comments - not use reflect.DeepEqual and other misc fixes

* Change the auto-populated value to be the full EmbeddingServer URL

* fix e2e tests

* small updates to examples

* Addressed PR comments - removed inline way of config

* Review comments - auto populate optimizer and change validation on EmbeddingServerRef

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

147 of 273 new or added lines in 7 files covered. (53.85%)

4 existing lines in 2 files now uncovered.

45322 of 72675 relevant lines covered (62.36%)

76.24 hits per line