umputun / ralphex / 22151409710

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: append progress files on restart instead of truncating (#130)

* fix: append progress files on restart instead of truncating

Switch from os.Create (truncate) to os.OpenFile with O_APPEND so
progress history is preserved when ralphex is restarted. On restart,
a separator line is written instead of a full header. The separator
matches the web parser sectionRegex and renders as a section boundary
in the dashboard.

Related to #129

* test: add edge case tests and godoc for append-on-restart

Add empty-file edge case test, web parser test for restart separator,
and update NewLogger godoc to document append behavior.

* fix: acquire file lock before stat to prevent TOCTOU race

Move lockFile() call before f.Stat() in NewLogger so the restart
detection (size > 0 check) is protected by the exclusive lock.
Without this ordering, a concurrent process could stat size==0,
block on the lock, then incorrectly write a full header after
another process already wrote content.

Also add proper cleanup (unlock + unregister) on the stat error path.

Run Details

22 of 29 new or added lines in 1 file covered. (75.86%)

3 existing lines in 2 files now uncovered.

5360 of 6553 relevant lines covered (81.79%)

186.95 hits per line