umputun / ralphex / 22151240466

82%

master: 83%

Build Type

Pull #130

github

Committed by umputun

Commit Message

fix: acquire file lock before stat to prevent TOCTOU race

Move lockFile() call before f.Stat() in NewLogger so the restart
detection (size > 0 check) is protected by the exclusive lock.
Without this ordering, a concurrent process could stat size==0,
block on the lock, then incorrectly write a full header after
another process already wrote content.

Also add proper cleanup (unlock + unregister) on the stat error path.

Pull Request Pull Request #130: fix: append progress files on restart instead of truncating

Coverage Stats

22 of 29 new or added lines in 1 file covered. (75.86%)

4 existing lines in 2 files now uncovered.

5359 of 6553 relevant lines covered (81.78%)

188.57 hits per line