kubeflow / sdk / 22144252595

77%

Build Type

push

github

Committed by web-flow

Commit Message

feat(trainer): Support namespaced TrainingRuntime in the SDK (#130)

* feat(backend): Support namespaced TrainingRuntime in the SDK

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Fixed bugs and validated current test cases

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Fixed pre-commit test failure

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Addressed comments

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Fixed no attribute 'DEFAULT_TIMEOUT' error

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Added namespace-scoped runtime to test cases

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Addressed fallback logic bugs

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Added scope field to Runtime

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Improved code

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Fixed copilot's comments

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Shadow duplicate runtimes, priority to ns

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Fixed bug

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Fixed copilot comments

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Improved test cases to validate all possible cases

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* small fix

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* lint fix

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* improved error message

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Moeed <shaikmoeed@gmail.com>

* refactored code

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* improve code

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* Removed RuntimeScope

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

* removed scope references and improved error handling as per kubeflow standards

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>

---------

Signed-off-by: Moeed Shaik <shaikmoeed@gmail.com>
Signed-off-by: Moeed ... (continued)

Run Details

62 of 72 new or added lines in 3 files covered. (86.11%)

12 existing lines in 2 files now uncovered.

4331 of 5656 relevant lines covered (76.57%)

2.3 hits per line