openconfig / featureprofiles / 22125841979

10%

push

github

Add deviation for explicit BGP RIB streaming config (#4955)

* Add deviation for explicit BGP RIB streaming config

Following BGP tests verify the BGP RIB state streamed through following YANG path: /network-instances/network-instance/protocols/protocol/bgp/rib

Arista devices need explicit BGP RIB streaming config to send data for the above YANG path.

* Update internal/cfgplugins/bgp.go

The function DeviationBgpRibStreamingConfigRequired is defined to return an error, but none of the call sites in this pull request check for it. This can lead to silent failures if the deviation is ever enabled for an unsupported vendor.

To make the code safer and more aligned with other test helpers, please consider changing the function to call t.Fatalf for unhandled vendors instead of returning an error. This will also simplify the call sites.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Add issuetracker URL in the deviations file

* Fix static analysis failure

"unnecessary use of fmt.Sprintf" in internal/cfgplugins/bgp.go:685
remove `fmt.Sprintf`

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

0 of 22 new or added lines in 3 files covered. (0.0%)

2300 of 22814 relevant lines covered (10.08%)

0.12 hits per line