NVIDIA / gpu-operator / 22121274427

26%

main: 28%

push

github

[Perf] Update labelGPUNodes() to reset updateLabels inside loop

As a golden rule of performance, we should never do work that is not necessary.
In the current implementation where updateLabels is declared outside the for loop,
if updateLabels becomes true for the first node in a large GPU cluster, it triggers
a PATCH request to the API for every subsequent node even when not necessary. This
maybe a cheap call but we should never do work that is not necessary. Moving updateLabels
inside of the for loop, reduces APi calls and load, along with improving reconcilliation time.

Signed-off-by: Sai Sindhur Malleni <smalleni@nvidia.com>

1 of 1 new or added line in 1 file covered. (100.0%)

3108 of 11901 relevant lines covered (26.12%)

0.59 hits per line