supabase / auth / 22120958351

69%

master: 69%

Build Type

Pull #2380

github

Committed by Chris Stockton

Commit Message

fix(hooks): propagate error objects from hook calls

Package `hookerrors` was meant to introduce consistent error
handling across `hookshttp` and `hookspgfunc`. However it was not
being used within the `hookshttp` package. This change fixes that
to have one consistent error mechanism supported across all hooks.

For http hooks specifically there is an error in the supabase docs
that I will resolve in a follow up pr. The status code from the
invoked hook should indicate the response status only for the auth
server. This means a response of 500 will be treated as a failed
invocation of the hook and the response body will not be ready.

Responses will only be read when the status code is 200 or 202. If
so it will read the body, if it is the body will be checked by the
hookserrors package for an error object. If present it will be
propagated to the original client.

Pull Request Pull Request #2380: fix(hooks): propagate error objects from hook calls

Run Details

7 of 7 new or added lines in 2 files covered. (100.0%)

15026 of 21731 relevant lines covered (69.15%)

80.54 hits per line