medplum / medplum / 22116322784

92%

push

github

Prevent client caching of Abort signals (#8446)

When React is in Strict Mode, effects are run twice
(https://react.dev/reference/react/StrictMode#fixing-bugs-found-by-re-running-effects-in-development).

When working on the Scheduling $find Pane, I added an effect with an
abort controller that would try to clean up any outstanding requests.
This was running once and getting removed by the strict mode double-up.

That had the surprising side-effect of leaving a rejected promise in the
client cache. That value represents that the specific request was
cancelled, not that any future requests should immediately reject as
aborted.

Adding this signal handler that removes the promise from the cache is an
incremental step. There is a broader problem if multiple requesters are
attached to the promise and the original aborts, but I am not handling
that at this time.

Signed-off-by: Noah Silas <noah@medplum.com>

17148 of 19445 branches covered (88.19%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

31296 of 33039 relevant lines covered (94.72%)

13732.41 hits per line