dickschoeller / gedbrowser / 22110158085

95%

master: 96%

push

github

Clean up and standardize test assertions across controller integration tests

Changes:
- Refactored assertion patterns in 9 controller test classes to follow the proven
  pattern from PersonControllerIT.testGetPersonsMiniSchoellerI2
- Converted separate status and body assertions to single assertThat() chains using
  .returns() and .matches() methods for fluent assertions
- Updated HeadControllerIT with @SuppressWarnings PMD annotations (3 tests)
- Updated FamilyControllerIT with @SuppressWarnings PMD annotations and 4 test assertions (4 tests)
- Updated PersonControllerIT with single assertThat chains (3 tests)
- Updated SubmitterControllerIT with single assertThat chains (9 tests refactored)
- Added @SuppressWarnings PMD annotations to 10 test classes for consistency:
  ChildrenControllerIT, NoteControllerIT, SourceControllerIT, SubmitterControllerIT,
  SubmissionControllerIT, SaveControllerIT, SpousesControllerIT, and ParentsControllerIT
- Added ControllerTestHelper.containsAll() static utility method to support the
  new assertion pattern with complex string content verification

Benefits:
- Improved code consistency and readability
- Single entry point for assertions reduces cognitive load
- Enables easier maintenance and future refactoring
- Standardized approach across all controller integration tests

2038 of 2304 branches covered (88.45%)

9448 of 9963 relevant lines covered (94.83%)

6.12 hits per line