99designs / gqlgen / 22099778124
0%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 0
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 0.0%. Remained the same
22099778124

push

github

web-flow 
Refactor slice marshaling to use MarshalSliceConcurrently helper. fixes #4018 (#4019)

* fix: resolve WaitGroup deadlock in slice marshaling with WorkerLimit (#4018)

Move concurrent slice marshaling logic from codegen/type.gotpl into a
shared, testable function graphql.MarshalSliceConcurrently. This fixes
a deadlock where wg.Add(len(v)) was called upfront but wg.Done() was
skipped when semaphore.Acquire failed due to context cancellation.

The fix uses per-goroutine wg.Add(1) only after successful semaphore
acquisition, ensuring wg.Wait() never blocks on goroutines that were
never launched.

Also adds comprehensive tests including a regression test that verifies
the deadlock scenario completes without hanging.

Closes #4018

* refactor: clean up comments in slice marshaling code

* fix: address golangci-lint issues in slice marshaling code

- Remove unnecessary loop variable copy (copyloopvar, Go 1.22+)
- Reformat long lines with golines (max 100 chars)
- Use assert.Empty instead of assert.Len(t, ret, 0) (testifylint)

* fix: return nil from MarshalSliceConcurrently when context cancellation skips elements

When a semaphore Acquire fails due to context cancellation, elements are
skipped but the function previously returned the array with nil holes.
Calling MarshalGQL on such an array causes a nil pointer panic. Now set
retNilFlag on Acquire failure and break the loop immediately, returning
nil consistent with the existing panic-recovery behavior.

* chore: regenerate batchresolver example after rebase

The batch resolver example was added on master but its generated code
was not updated with the MarshalSliceConcurrently template changes
after rebase.

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 22099778124.1 0
0.0
 GitHub Action Run
Source Files on build 22099778124
Detailed source file information is not available for this build.