IgniteUI / igniteui-angular / 22099217653

92%

master: 92%

push

github

Fix column width issues in grid state persistence 20.1.x (#16916)

* fix(state): column width issue when all columns are hidden in grid state

- Prevent setting _columnWidth to "0px" when all columns are hidden
- Preserve valid column widths for when columns are unhidden
- Add test to verify column widths are preserved after state restoration

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* test(state): Update test to properly validate column width preservation

- Adjust test expectations to handle columns constrained by minWidth
- Verify that columns don't all end up with the same minimum width
- Test passes successfully

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* test(*): update column-hiding test to reflect correct behavior

- column width should not be 0px when all columns hidden
- This allows proper width restoration when columns are unhidden
- All column hiding tests pass successfully

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* chore(*): Address code review feedback

- Use explicit check for '0px' instead of parseFloat for clarity
- Remove hardcoded width assertion in test for better maintainability
- All tests still pass successfully

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* refactor(*): to eliminate code duplication

- Extract _updateColumnDefaultWidths helper method
- Remove redundant condition check
- Improve code maintainability
- All tests still pass

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* fix(state): Only persist user-set column widths in grid state

- Only save width to state if widthSetByUser or columnWidthSetByUser is true
- Prevents auto-calculated widths from becoming fixed after state restore
- Handle width restoration to skip if undefined
- All tests pass

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* test(pivot grid state): fixing test to not persist calculated column width

* refactor... (continued)

13975 of 16388 branches covered (85.28%)

15 of 15 new or added lines in 2 files covered. (100.0%)

27962 of 30495 relevant lines covered (91.69%)

35218.14 hits per line