IgniteUI / igniteui-angular / 22091857401

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix column width issues in grid state persistence (#16901)

* Initial plan

* Fix column width issue when all columns are hidden in grid state

- Prevent setting _columnWidth to "0px" when all columns are hidden
- Preserve valid column widths for when columns are unhidden
- Add test to verify column widths are preserved after state restoration

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* Update test to properly validate column width preservation

- Adjust test expectations to handle columns constrained by minWidth
- Verify that columns don't all end up with the same minimum width
- Test passes successfully

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* Update column-hiding test to reflect correct behavior

- Update test expectation - column width should not be 0px when all columns hidden
- This allows proper width restoration when columns are unhidden
- All column hiding tests pass successfully

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* Address code review feedback

- Use explicit check for '0px' instead of parseFloat for clarity
- Remove hardcoded width assertion in test for better maintainability
- All tests still pass successfully

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* Refactor to eliminate code duplication

- Extract _updateColumnDefaultWidths helper method
- Remove redundant condition check
- Improve code maintainability
- All tests still pass

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* Fix: Only persist user-set column widths in grid state

- Only save width to state if widthSetByUser or columnWidthSetByUser is true
- Prevents auto-calculated widths from becoming fixed after state restore
- Handle width restoration to skip if undefined
- All tests pass

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* test(pivot grid state): fixing test to not persist calculated column width

* refactor: Extract duplic... (continued)

Run Details

14367 of 16927 branches covered (84.88%)

15 of 15 new or added lines in 2 files covered. (100.0%)

21 existing lines in 2 files now uncovered.

28965 of 31629 relevant lines covered (91.58%)

34671.57 hits per line