umputun / docker-logger / 22087418881

79%

master: 79%

Build Type

Pull #56

github

Committed by umputun

Commit Message

fix: address remaining code review findings

- replace log.Fatalf in activate() with graceful channel close
- extract closeStreamer helper to deduplicate close logic
- replace NewEventNotif 5 params with EventNotifOpts struct
- add error tracking to LogStreamer via atomic.Value and Err()
- fix syslog log level, godoc grammar, README typos
- fix Test_makeLogWritersMixed to use behavioral verification
- fix resource leak in runEventLoop on closed events channel
- make Test_makeLogWritersInvalidDir portable

Pull Request Pull Request #56: Fix code review findings: timestamps, error handling, tests, docs

Run Details

76 of 86 new or added lines in 4 files covered. (88.37%)

4 existing lines in 1 file now uncovered.

371 of 471 relevant lines covered (78.77%)

7.53 hits per line