nestjs / nest / e10f6819-b1b4-4f6a-81e5-857fe08aabe0

90%

master: 90%

Pull #16366

circleci

fix(websockets): detect native ws clients before calling emit

The emitMessage() method checked for client.emit first, but native
WebSocket clients from the ws package inherit from EventEmitter and
also have an emit method that only dispatches events locally. This
caused WsException errors to be emitted as local events instead of
being sent over the wire, resulting in the e2e test timing out.

Added an isNativeWebSocket() check that looks for a numeric readyState
property (per the WebSocket spec) to reliably distinguish native WS
clients from Socket.IO sockets. Also fixed prettier formatting on the
emitMessage generic signature, and updated test mocks to include
readyState on the native WS client stub.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2867 of 3571 branches covered (80.29%)

8 of 9 new or added lines in 1 file covered. (88.89%)

7468 of 8313 relevant lines covered (89.84%)

19.04 hits per line