splunk / splunk-operator / 22025752571

85%

main: 87%

Build Type

Pull #1699

circleci

Committed by vivekr-splunk

Commit Message

Use legacy mode for all Standalone deployments (temporary fix)

This commit temporarily disables Platform SDK StatefulSet creation
and uses legacy mode for all Standalone deployments to ensure
compatibility with existing secret configurations.

Root Cause:
You correctly identified that SDK initialization happens once at
startup, so that's not the issue. The real problem is that the
SDK's secret resolution expects secrets in a specific format/location
that differs from the legacy format used by existing deployments
and smoke tests.

Legacy format:  splunk-{namespace}-secret
SDK expected format: {crName}-credentials (with PlatformConfig)

The SDK SHOULD support the legacy secret format as a fallback, but
implementing that properly requires:
1. Modifying SDK's Kubernetes secret provider to check legacy names
2. Ensuring proper backwards compatibility
3. Testing both formats

Temporary Solution:
Always use getStandaloneStatefulSetLegacy() for now. This ensures:
✅ Smoke tests pass (they use legacy secrets)
✅ Existing deployments work unchanged
✅ SDK infrastructure (CRDs, controllers) still gets deployed
✅ No hanging or timeouts in reconciliation
✅ Fast, predictable behavior

Future Work (TODO):
- Implement SDK secret provider fallback to legacy naming
- Add SecretAdapter integration to handle both formats gracefully
- Enable SDK mode by default once secret compatibility is proven

Changes:
- pkg/splunk/enterprise/standalone.go: Simplified getStandaloneStatefulSet
  to always return legacy implementation
- Removed unused certificate and secret imports
- Added clear TODO for future SDK enablement

This is a pragmatic fix that unblocks testing while we implement
proper SDK secret format compatibility.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Pull Request Pull Request #1699: [SPIKE] Platform SDK Integration for Standalone Controller

Run Details

152 of 248 new or added lines in 4 files covered. (61.29%)

1 existing line in 1 file now uncovered.

11087 of 12932 relevant lines covered (85.73%)

28.88 hits per line