popstas / talks-reducer / 22022714639

68%

Build Type

push

github

Committed by popstas

Commit Message

fix: GUI stop button doesn't kill ffmpeg

- Add stop_requested param to run_timed_ffmpeg_command()
  that checks the flag in the readline loop and force-kills
  the process via process group on abort
- Start ffmpeg with start_new_session=True on Unix so
  os.killpg can target the entire process group
- Add _force_kill_process() helper: SIGTERM to group,
  wait 2s, then escalate to SIGKILL
- Remove premature _hide_stop_button() from
  _stop_processing() — the worker finally block handles it
- Pass stop callback from reporter through pipeline to
  all three run_timed_ffmpeg_command() calls

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

8 of 33 new or added lines in 2 files covered. (24.24%)

136 existing lines in 3 files now uncovered.

5946 of 8760 relevant lines covered (67.88%)

0.68 hits per line