temporalio / sdk-go / 22009346831
60%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 140
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.456% (+0.3%) from 60.118%
22009346831

push

github

web-flow 
Add worker heartbeat support (#2186)

* Add worker heartbeat support

Implement worker heartbeats that report worker status, slot usage, and metrics
to the server via the WorkerHeartbeat RPC.

Key changes:
- Add HeartbeatMetricsHandler to capture metrics needed for heartbeats
- Add internal_worker_heartbeat.go for heartbeat worker management
- Add hostmetrics package for CPU/memory usage reporting
- Plumb heartbeat data through workers (workflow, activity, nexus, local activity)
- Add integration tests for worker heartbeat functionality
- Fix nil pointer in shutdownWorker when heartbeating is disabled

* vendor gopsutil

* PR feedback

* Sort plugin names

* Create new hostinfo package

* make methods/structs private, remove aw.workerHeartbeatManager

* tighten lock, consolidate describeNamespace calls to a single call in AggregatedWorker.start()

* simplify heartbeat metrics, decouple poller/worker type from WithTags()

* remove unused nexus worker, tighten heartbeat callback and make concurrent-safe

* Fix tests

* Fix cursor discovered bugs, fix integ tests

* Rename hostinfo to sysinfo, add interval enforcement, rename mutexes, clarify code

* fix bugs cursor found, sync.oncevalue, separate poll time tracking out of metrics

* Add back resource tuner tests that got dropped

* Fix tests

* Fix tests, disable heartbeating for normal tests, bump dev server version

* Finish renames of sysInfoProvider, handle Time.IsZero(), make pollTimeTracker more idiomatic, move namespace capabilities to AW, remove Get from func names

* Fix tests

* remove extra default logger addition, remove dead code

* forgot a change..

* fix unit tests

* Fix eventually expectation for slower CI machines, fix race with heartbeat worker creation and callback registration

* Gate all sticky cache tests behind maxWorkflowCacheSize checks so it passes CI

* loosen workerInfo.CurrentStickyCacheSize and workerInfo.TotalStickyCacheHit checks

* Fix up TestWorkerHeartbeatStickyCache... (continued)

19517 of 32283 relevant lines covered (60.46%)

14047.0 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
3
0.0
 0.0% internal_nexus_worker.go
14
0.0
 0.0% internal_nexus_task_poller.go
48
70.93
 0.55% tuning.go
68
77.02
 -0.82% internal_worker_base.go
76
71.28
 -0.14% client.go
194
76.64
 -0.83% internal_task_pollers.go
336
74.2
 0.7% internal_worker.go
388
59.31
 0.1% internal_workflow_client.go
Jobs
ID Job ID Ran Files Coverage
1 22009346831.1 140
60.46
 GitHub Action Run
Source Files on build 22009346831