splunk / splunk-operator / 22009355752

85%

main: 87%

Build Type

Pull #1699

circleci

Committed by vivekr-splunk

Commit Message

Fix unit test failures in Platform SDK integration

This commit fixes 4 failing unit tests after the Platform SDK integration:

1. Fixed 3 SecretAdapter tests (TestSecretAdapter_SDKMode,
   TestSecretAdapter_SDKMode_SecretNotReady,
   TestSecretAdapter_SDKMode_SecretVersioning) by adding PlatformConfig
   CRD scheme registration. The tests were failing with:
   "no kind is registered for the type v4.PlatformConfig in scheme"

2. Fixed TestApplyStandalone panic by adding nil check for sdkRuntime
   in getStandaloneStatefulSet. When sdkRuntime is nil (legacy tests),
   the function now falls back to getStandaloneStatefulSetLegacy which
   uses the pre-SDK implementation.

Changes:
- pkg/splunk/enterprise/secret_adapter_test.go: Import platformv4 and
  register PlatformConfig scheme in all SDK-mode tests
- pkg/splunk/enterprise/standalone.go: Add nil check and legacy
  fallback path in getStandaloneStatefulSet, add
  getStandaloneStatefulSetLegacy function for backward compatibility

All enterprise package tests now pass successfully.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Pull Request Pull Request #1699: [SPIKE] Platform SDK Integration for Standalone Controller

Run Details

142 of 360 new or added lines in 4 files covered. (39.44%)

1 existing line in 1 file now uncovered.

11077 of 13044 relevant lines covered (84.92%)

28.66 hits per line