21996396650

Committed 13 Feb 2026 05:31PM UTC coverage: 96.871% (-0.04%) from 96.906%

Build # 21996396650

Build Type

Pull #2657

github

Committed by

ericproulx

Commit Message

Instantiate validators at definition time

- Store validator instances in ParamsScope/ContractScope and have Endpoint#run_validators read them directly
- Remove ValidatorFactory indirection and eagerly compute validator messages/options in constructors
- Normalize Grape::Exceptions::Validation params handling and refactor validator specs to define routes per example group
- Drop test-prof dependency and its spec config

Co-authored-by: Cursor <cursoragent@cursor.com>

Pull Request Pull Request #2657: Instantiate validators at definition time

Run Details

1056 of 1141 branches covered (92.55%)

Branch coverage included in aggregate %.

163 of 164 new or added lines in 21 files covered. (99.39%)

1 existing line in 1 file now uncovered.

3309 of 3365 relevant lines covered (98.34%)

37558.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.83

/lib/grape/exceptions/validation_errors.rb

# frozen_string_literal: true

module Grape
  module Exceptions
    class ValidationErrors < Base
      ERRORS_FORMAT_KEY = 'grape.errors.format'
      DEFAULT_ERRORS_FORMAT = '%<attributes>s %<message>s'

      include Enumerable

      attr_reader :errors

      def initialize(errors: [], headers: {})
        @errors = errors.group_by(&:params)
        super(message: full_messages.join(', '), status: 400, headers: headers)
      end

      def each
        errors.each_pair do |attribute, errors|
          errors.each do |error|
            yield attribute, error
          end
        end
      end

      def as_json(**_opts)
        errors.map do |k, v|
          {
            params: k,
            messages: v.map(&:to_s)
          }
        end
      end

      def to_json(*_opts)
        as_json.to_json
      end

      def full_messages
        messages = map do |attributes, error|
          I18n.t(
            ERRORS_FORMAT_KEY,
            default: DEFAULT_ERRORS_FORMAT,
            attributes: translate_attributes(attributes),
            message: error.message
          )
        end
        messages.uniq!
        messages
      end
    end
  end
end

1	# frozen_string_literal: true
2
3	module Grape	37✔
4	module Exceptions	37✔
5	class ValidationErrors < Base	37✔
6	ERRORS_FORMAT_KEY = 'grape.errors.format'	37✔
7	DEFAULT_ERRORS_FORMAT = '%<attributes>s %<message>s'	37✔
8
9	include Enumerable	37✔
10
11	attr_reader :errors	37✔
12
13	def initialize(errors: [], headers: {})	37✔
14	@errors = errors.group_by(&:params)	11,110✔
15	super(message: full_messages.join(', '), status: 400, headers: headers)	11,110✔
16	end
17
18	def each	37✔
19	errors.each_pair do \|attribute, errors\|	11,302✔
20	errors.each do \|error\|	13,832✔
21	yield attribute, error	14,664✔
22	end
23	end
24	end
25
26	def as_json(**_opts)	37✔
27	errors.map do \|k, v\|	64✔
28	{
29	params: k,	64✔
30	messages: v.map(&:to_s)
31	}
32	end
33	end
34
35	def to_json(*_opts)	37✔
UNCOV 36	as_json.to_json	×
37	end
38
39	def full_messages	37✔
40	messages = map do \|attributes, error\|	11,174✔
41	I18n.t(	14,536✔
42	ERRORS_FORMAT_KEY,
43	default: DEFAULT_ERRORS_FORMAT,
44	attributes: translate_attributes(attributes),
45	message: error.message
46	)
47	end
48	messages.uniq!	11,174✔
49	messages	11,174✔
50	end
51	end
52	end
53	end

ruby-grape / grape / 21996396650

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous