hicommonwealth / commonwealth / 21992591836

38%

Build Type

push

github

Committed by web-flow

Commit Message

Enforce policy vs projection architecture rule and fix misclassified files (#13381)

* refactor: enforce policy vs projection architecture rule and fix misclassified files

Reclassify 5 misclassified policies as projections:
- CreateUnverifiedUser → aggregates/user/
- Governance → aggregates/chain-events/
- Nominations → aggregates/community/
- ReactionWorker → aggregates/reaction/
- UpgradeTier → aggregates/user/ (rename only)

Split hybrid files:
- ChainEventCreated.policy: extract DB-mutating handlers into ChainEventCreated.projection
- FarcasterWorker.policy: extract FarcasterReplyCastDeleted into FarcasterContest.projection

Eliminate Project... command indirection:
- PredictionMarket.policy → PredictionMarket.projection (inline logic)
- ProjectLaunchpadTrade.command → LaunchpadTrade.projection
- Remove ProjectPredictionMarketProposal/Market commands and schemas

Update consumer registrations, barrel exports, test imports, and docs.

Completed GitHub issue #13379

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: relocate projection handlers from policies/ to aggregates/

Move handleCommunityStakeTrades and handleReferralFeeDistributed from
policies/handlers/ to aggregates/community/handlers/ where their
projection consumers live. Move chainNodeMustExist utility from
policies/utils/utils to the shared utils/utils module.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor: rename projection helpers to projections/project* convention

Rename handlers/handle* to projections/project* for projection helper
files, aligning the naming convention with the projection architecture.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: break circular dependency in model utils by extracting chainNodeMustExist

Moving chainNodeMustExist to utils/utils.ts created a circular import:
database.ts → models/ → models/thread.ts → utils/utils.ts → database.ts

Extracted chainNodeMustExist into its own utils/chainNodeUtils.ts mod... (continued)

Run Details

2025 of 5910 branches covered (34.26%)

Branch coverage included in aggregate %.

18 of 51 new or added lines in 6 files covered. (35.29%)

1 existing line in 1 file now uncovered.

3619 of 9225 relevant lines covered (39.23%)

47.53 hits per line