redhat-developer / yaml-language-server / 21992801998

85%

master: 80%

push

github

fix: pass loadSchema callback to pickSchemaDialect (#1176)

* fix: pass loadSchema callback to pickSchemaDialect

pickSchemaDialect is a module-level function but used `this.loadSchema(s)`
on line 1338, where `this` is undefined (strict mode). This caused a
TypeError when resolving schemas with custom (non-standard) $schema URIs
that require loading the meta-schema to infer the dialect.

The fix adds an optional `loadSchema` callback parameter. The caller in
`resolveSchemaContent` (a class method with proper `this` context) passes
`this.loadSchema.bind(this)` via a closure variable.

When `loadSchema` is not provided, the function returns `undefined` for
unknown dialects instead of crashing.

* Fix prettier formatting error

Signed-off-by: David Thompson <davthomp@redhat.com>

* Add test suite that fails without the fix

- Add an await for a promise that was left dangling in order to properly
propagate the error.
- Remove other test suite; the test was passing with and without the fix.

Signed-off-by: David Thompson <davthomp@redhat.com>

* Increase timeout

It's timing out on macOS

Signed-off-by: David Thompson <davthomp@redhat.com>

---------

Signed-off-by: David Thompson <davthomp@redhat.com>
Co-authored-by: Holger Bartnick <holger.bartnick@data-experts.de>
Co-authored-by: David Thompson <davthomp@redhat.com>

2907 of 3632 branches covered (80.04%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

4299 of 4846 relevant lines covered (88.71%)

258891.01 hits per line