dart-lang / native / 21942795171

74%

push

github

[record_use] Rework `Definition`s (#3075)

This change addresses the ambiguity issues in how we identify Dart definitions. The new API ensures we can unambiguously capture and reference all kinds of statically resolved symbols across classes, extensions, and extension types.

Related bugs:

* https://github.com/dart-lang/native/issues/2888
* https://github.com/dart-lang/native/issues/3062

### Key Changes

#### 1. Structured `Name` with Kinds and Disambiguators
Each segment in the path is now a `Name` object containing:
* `name`: The string identifier.
* `kind`: A `DefinitionKind` (e.g., `classKind`, `methodKind`, `getterKind`, `setterKind`, `operatorKind`).
* `disambiguators`: A `Set<DefinitionDisambiguator>` used to distinguish between `static` and `instance` members, which is critical for extensions and extension types.

The `kind` and `disambiguators` are null. Setting them non-null will be done in a follow up PR.

#### 2. Canonical URI `toString()`
Implemented a "smart" `toString()` that produces valid, URI-friendly strings for use in tooling and documentation.
* **Format:** `library#kind:name@disambiguator::kind:name`
* **Example:** `package:my_pkg/foo.dart#class:MyClass::method:myMethod@static`

(Taken from discussions on https://github.com/dart-lang/language/issues/4616)

37 of 58 new or added lines in 2 files covered. (63.79%)

5982 of 8065 relevant lines covered (74.17%)

73.87 hits per line