Qiskit / qiskit / 21940126476

88%

main: 88%

Build Type

Pull #15681

github

Committed by mergify[bot]

Commit Message

Fix ParameterExpression.sympify() for RPOW operations (#15642)

* Add SciPyOptimizer (#6319)

* Add ScipyMinimizer

* fix test and lint

* use ScipyMinimizer to other scipy's optimizers

* support P_BFGS

* add doc strings and refactoring

* add max_evals_grouped

* add docstring for max_evals_grouped

* rename to SciPyOptimizer

* fix test

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* refactor

* add releasenote

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Fix string formatting (#9540)

* Extend error message when target disjoint connectivity (#10733)

* Extend error message when target disjoint connectivity

* text in the exception

* Apply suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* changing the phrasing

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Fix ParameterExpression.sympify() for RPOW operations

Fixes #15583

The sympify() method was not correctly handling reverse power
operations (RPOW). When converting ParameterExpression to sympy,
RPOW operations need to swap operands (rhs ** lhs instead of
lhs ** rhs) to match the Rust implementation.

This fix adds special handling for RPOW, RDIV, and RSUB operations
to correctly swap operands before applying the operation.

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=Eruis2579

* Add test and release note for RPOW sympify fix

- Add test_sympify_rpow_operand_order() to verify the fix for issue #15583
- Add release note documenting the bug fix

This addresses reviewer feedback to add tests and release notes.

* Add comprehensive tests for all reverse operations (RPOW, RDIV, RSUB)

This improves test coverage for the sympify fix by testing all three
reverse operation types that were added in the fix. This addresses
the Coveralls coverage report showing only 25% coverage.

* Fix POW operation to use RPOW when LHS is Parame... (continued)

Pull Request Pull Request #15681: Fix ParameterExpression.sympify() for RPOW operations (backport #15642)

Run Details

30 of 34 new or added lines in 2 files covered. (88.24%)

40 existing lines in 3 files now uncovered.

96668 of 109418 relevant lines covered (88.35%)

1203318.33 hits per line