xlnt-community / xlnt / 82943c9d-176d-4815-b0fa-1355a080f42b

84%

push

circleci

Move string casts for C++20 and related utils to a public header (#144)

Since C++20, `u8` string literals must be used with `const char8_t *`,
`std::u8string` and `std::u8string_view`. They can no longer be used
with classic narrow strings, like with C++11, C++14 and C++17.

However, due to string encoding issues for compilers that do not use
UTF-8 by default, explained in issue xlnt-community#134 and now
documented in our
[README.md](https://github.com/xlnt-community/xlnt/blob/master/README.md#string-encoding),
it might make sense to define a `u8` literal and pass it to XLNT
functions taking `std::string` as parameter, while ensuring that strings
are encoded as UTF-8. The utils that have been moved help with this.

15277 of 19954 branches covered (76.56%)

6 of 7 new or added lines in 2 files covered. (85.71%)

12511 of 14901 relevant lines covered (83.96%)

12205.53 hits per line