2661
98%
master: 98%

Ran 07 Sep 2016 09:33AM UTC

Jobs 2

Files 113

Run time 1min

Badge

Embed ▾

pending completion

Build # 2661

Build Type

push

travis-ci

Committed by

mhl

Commit Message

Fix the exception on moderating a message created with moderation off

This test was introduced in 35f54775889; when that commit was written,
confirming a message created with moderation off didn't causes it to be
marked as moderated.  It thus expected an error about the Moderation
object not existing for that message, and for the message to stay with
moderated == False.

However, cbba85a1dd7b695f7 changed the behaviour of the
'recently_confirmated' method (the one that's called to indicate that a
message has been confirmed) to mark a message as moderated on
confirmation if moderation was off.  In addition, 88e3c97cb4fda685
introduced the change that a ValidationError would be thrown from
moderate() if the message was already moderated. (I don't think this is
the right exception to be throwing for that case, but it follows the
convention in the existing code, so I'm not changing that.)

This test seems to be of limited usefulness since cbba85a, since it's
only in odd situations that moderate() will be called on a message
created with moderated == True, and that's now the case for messages
created when moderation was off. However, I've updated the test for the
current behaviour, by:

  (a) Checking for ValidationError instead of Moderation.DoesNotExist

  (b) Removing the assertion that moderated == False

Run Details

8240 of 8398 relevant lines covered (98.12%)

1.96 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2661.1 (DB=postgres)	07 Sep 2016 09:34AM UTC	0	98.12	Travis Job 2661.1
2	2661.2 (DB=sqlite3)	07 Sep 2016 09:33AM UTC	0	98.12	Travis Job 2661.2

Source Files on build 2661

Detailed source file information is not available for this build.

ciudadanointeligente / write-it / 2661
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2661

ciudadanointeligente / write-it / 2661 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2661

ciudadanointeligente / write-it / 2661
98%
master: 98%

README BADGES
x