stacklok / toolhive / 21897339384

62%

push

github

Add client skill metadata for skill path resolution (#3712)

* Add client skill metadata for skill path resolution (#3647)

Extend clientAppConfig with skill-specific fields (SupportsSkills,
SkillsGlobalPath, SkillsProjectPath, SkillsPlatformPrefix) so the
skill installer knows where to place skill files for each client.

Populate skill paths for ClaudeCode, Codex, and OpenCode matching
the canonical paths from skillet's client registry. Replace unused
ScopeSystem with ScopeProject for project-local skill installations.

Export ValidateSkillName from pkg/skills/validator.go so callers can
validate skill names against the Agent Skills specification without
reimplementing the regex.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address PR review feedback for skill metadata

- Inline name validation in validateFields, removing the validateName
  wrapper that scattered empty-string handling across two functions
- Add doc comment to SkillsPlatformPrefix explaining purpose, key
  constraints, and nil behavior

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix gci lint issue in clientAppConfig field alignment

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Deduplicate client lookup loop via lookupClientAppConfig

Refactor CreateClientConfig, retrieveConfigFileMetadata, Upsert, and
SupportsSkills to use the existing lookupClientAppConfig helper instead
of reimplementing the same iteration pattern. This also fixes the
pointer semantics in the first two (they previously took &cfg of the
loop variable copy instead of indexing into the slice).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Introduce typed Platform enum for platform prefix map keys

Replace bare string keys ("linux", "darwin", "windows") in
PlatformPrefix and SkillsPlatformPrefix maps with a typed Platform
type and constants. This prevents typos in map keys from silently
failing at runtime.

Co-... (continued)

96 of 102 new or added lines in 4 files covered. (94.12%)

42840 of 69538 relevant lines covered (61.61%)

76.64 hits per line