shader-slang / slang-rhi / 21874377715
69%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 240
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.652% (-11.6%) from 69.225%
21874377715

push

github

web-flow 
Expand on testing & debugging code + change naming/structure of debug options (#622)

* Rework how downstream debug works and naming of debug options

* add missing condition for when to add a debug callback (vulkan)

* use `friend` for encapsulation instead of `extern "C"`

* Address code review

1. enum class DebugLayerOptions ==> struct DebugLayerOptions
    * testing infrastructure was modified accordingly
2. moved members from IRHI to RHI. Other functions were moved as needed
3. removed flags from `DebugMessageType` and `DebugMessageSource`
4. adjusted debug layer logic for d3d12 to disable GPU-AV
5. removed DebugDeviceOptions, using `bool enable.*` instead

* Addressed review

* Removed all global-scope getRHI() wrapper functions
* Moved all `incrementLiveDeviceCount` to `class RHI` and exposed as a `public` function. Separated `RHI` into a header file since this is now needed to access `incrementLiveDeviceCount`.
    * The live device counter is now an atomic<uint32_t>
* Moved `DebugMessageType` and `DebugMessageSource` string conversion functions to the function `enumToString` in the corresponding files
* Added `DeviceImpl::setupDebugLayer` to manage debug-layer logic for `d3d12-device`
* Changed logic so that if using a release build for slang-rhi testing, GPU_TEST defaults to zero validation layers no matter what. Debug build listens to hints.
    * `DebugLayerOptionsBuilder` is now used for setting up per-test debug layer options (ignored if not SLANG_RHI_DEBUG)
* If missing debug-layer support or validation support of a particular type, we no longer `printError` and return `SLANG_FAIL`. We instead `printWarning` and skip enabling the particular feature (this was made to be consistent across `vk-device` and `d3d12-device`).
* added the new test `.cpp` file to the cmake list

* rename `m_totalLiveDevices` to `m_liveDeviceCount`

* run `pre-commit` and address review.

mostly clean-up (removing unused, styling, etc...)
and re-architecturing f... (continued)

9391 of 18910 branches covered (49.66%)

Branch coverage included in aggregate %.

145 of 253 new or added lines in 10 files covered. (57.31%)

5815 existing lines in 36 files now uncovered.

27548 of 45162 relevant lines covered (61.0%)

251645.11 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
47.18
 1.59% src/strings.h
4
55.85
 1.48% src/enum-strings.cpp
4
67.34
 -0.47% src/rhi.cpp
8
80.44
 -1.71% src/d3d11/d3d11-device.cpp
9
63.89
 -4.14% src/d3d/d3d-utils.cpp
25
78.8
 1.38% src/vulkan/vk-device.cpp
57
3.09
 -72.75% src/d3d12/d3d12-device.cpp

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 -100.0% src/d3d12/d3d12-shader-object.h
1
80.44
 -1.71% src/d3d11/d3d11-device.cpp
1
84.34
 -0.51% src/core/offset-allocator.cpp
3
59.84
 0.41% src/device.cpp
3
78.8
 1.38% src/vulkan/vk-device.cpp
3
86.9
 -4.76% src/slang-context.h
4
59.46
 -4.73% include/slang-rhi/acceleration-structure-utils.h
4
52.97
 -0.37% src/debug-layer/debug-device.cpp
5
48.51
 -4.95% src/core/string.h
10
6.67
 -66.67% src/nvapi/nvapi-util.h
11
63.89
 -4.14% src/d3d/d3d-utils.cpp
11
0.0
 -46.15% src/d3d12/d3d12-resource.h
14
74.33
 -4.55% src/shader.cpp
17
0.0
 -88.0% src/d3d12/d3d12-texture.h
18
0.0
 -78.57% src/d3d12/d3d12-bindless-descriptor-set.h
18
0.0
 -100.0% src/d3d12/d3d12-shader-program.cpp
20
0.0
 -64.86% src/d3d12/d3d12-buffer.h
20
0.0
 -73.53% src/d3d12/d3d12-sampler.cpp
32
3.7
 -68.52% src/d3d12/d3d12-descriptor-heap.h
33
0.0
 -62.9% src/d3d12/d3d12-fence.cpp
37
0.0
 -33.07% src/d3d12/d3d12-resource.cpp
52
0.0
 -68.89% src/d3d12/d3d12-constant-buffer-pool.cpp
57
0.0
 -85.92% src/d3d12/d3d12-shader-object-layout.h
92
0.0
 -95.69% src/d3d12/d3d12-shader-table.cpp
112
0.0
 -78.41% src/d3d12/d3d12-bindless-descriptor-set.cpp
143
0.0
 -89.58% src/d3d12/d3d12-buffer.cpp
149
0.0
 -82.46% src/d3d12/d3d12-descriptor-heap.cpp
152
0.0
 -90.17% src/d3d12/d3d12-query.cpp
243
0.0
 -65.86% src/d3d12/d3d12-texture.cpp
270
0.0
 -49.07% src/d3d12/d3d12-acceleration-structure.cpp
374
0.0
 -63.38% src/d3d12/d3d12-utils.cpp
404
0.0
 -83.36% src/d3d12/d3d12-shader-object.cpp
476
0.0
 -70.79% src/d3d12/d3d12-pipeline.cpp
568
0.0
 -92.03% src/d3d12/d3d12-shader-object-layout.cpp
1148
3.09
 -72.75% src/d3d12/d3d12-device.cpp
1309
0.0
 -80.57% src/d3d12/d3d12-command.cpp
Jobs
ID Job ID Ran Files Coverage
1 windows-x86_64 - 21874377715.1 217
55.82
 GitHub Action Run
2 macos-aarch64 - 21874377715.2 158
38.57
 GitHub Action Run
3 linux-x86_64 - 21874377715.3 167
58.36
 GitHub Action Run
Source Files on build 21874377715