dignifiedquire / sonora / 21865288327

95%

push

github

fix: address remaining code review issues (second pass)

Fixes all remaining items from review1.md across all tiers:

Tier 1 — Must Fix:
- Fix FFI README C example with correct function signatures
- Fix BENCHMARKS.md arithmetic errors in ratio columns (0.56→0.58, 1.07→1.05, 1.15→1.17)
- Add missing keywords/categories to sonora-aec3 Cargo.toml
- Fix noise_suppressor middle window comment (64→65 samples)
- Fix panic_guard doctests (ignore→text blocks for pub(crate) macros)
- Add FFI panic guards to wap_destroy, wap_recommended_stream_analog_level,
  wap_stream_delay_ms

Tier 2 — Should Fix:
- Fix partial_cmp().unwrap() NaN panics in render_signal_analyzer,
  reverb_decay_estimator, interpolated_gain_curve
- Fix is_confident not reset in speech_level_estimator::reset()
- Remove duplicate lib.rs doc example (keep README.md include_str only)
- Fix sonora-simd README to mention SSE2 runtime detection
- Remove stale "Step 8" porting breadcrumb from vad_wrapper
- Remove "C++ TODO" references from fast_math.rs
- Fix #[cfg(test)] placement before doc comment in activations.rs
- Fix dBFS range doc in audio_util.rs
- Remove redundant sonora-common-audio dev-dependency
- Replace "robust" AI slop in quantile_noise_estimator

Tier 3 — Cleanup:
- Rename LTR_FEATURE_THR→LRT_FEATURE_THR (typo fix) across 3 files
- Rename ONE_BY_WIDTH_PLUS_2→ONE_OVER_TWO_WIDTH (misleading name)
- Deduplicate X2_BAND_ENERGY_THRESHOLD to common.rs (was in 4 files)
- Deduplicate BLOCKS_TO_HOLD_ERLE to common.rs (was in 2 files)
- Rename K_SQRT2_SIN→SQRT2_SIN, K_DBFS_NORMALIZATION→DBFS_NORMALIZATION
- Fix sonora/README.md stale cbindgen link reference

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

29 of 32 new or added lines in 12 files covered. (90.63%)

29250 of 31016 relevant lines covered (94.31%)

55285.9 hits per line