dignifiedquire / sonora / 21864219555

95%

Build Type

push

github

Committed by dignifiedquire

Commit Message

fix: address remaining code review issues across all tiers

Tier 1 (must fix):
- Add "webrtc" keyword to sonora Cargo.toml
- Fix "C API" reference in audio_processing.rs doc comment
- Replace unreachable!() with panic!() in high_pass_filter constructor
- Enforce minimum FFT sizes (Real >= 32, Complex >= 16) in pffft.rs
- Clean up SIMD_SZ comment references

Tier 2 (should fix):
- Remove dead clone-mutate-discard + unused reset_level_estimator_state
- Fix copy-paste dimension error in rnn_vad/weights.rs
- Remove debug_assert!(false) no-op in echo_remover_metrics.rs
- Inline false / remove dead code in submodule_states.rs
- Remove log_render_call no-op and its caller
- Fix swap_queue docs (not lock-free SPSC)
- Add doc comments to all ~100 AEC3 config public fields
- Remove "field trials" C++ jargon from config.rs

Tier 3 (nits):
- Fix C++ identifiers in subtractor.rs comment
- Centralize NUM_FRAMES_PER_SECOND, BLOCK_SIZE_MS constants
- Unify MIN_LEVEL_DBFS precision, import in noise_level_estimator
- Name PCM limit constants in noise_suppressor.rs
- Replace 500.0 literal with FEATURE_UPDATE_WINDOW_SIZE
- Replace magic 32000 with MaxProcessingRate in FFI conversions
- Fix panic_guard doctests (mark as ignore)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

19 of 22 new or added lines in 11 files covered. (86.36%)

1 existing line in 1 file now uncovered.

29246 of 31012 relevant lines covered (94.31%)

55323.05 hits per line