nestjs / nest / 4be5b7a3-a46b-47a1-ac30-fea040e374e6

90%

master: 90%

Build Type

Pull #16336

circleci

Committed by manureja64

Commit Message

fix(websockets): deliver exception errors to native ws clients

BaseWsExceptionFilter used client.emit() to send exception payloads,
which only works with socket.io. For native WebSocket clients (ws
library), emit() is just EventEmitter.emit() and does not send data
over the wire, causing exceptions to be silently swallowed.

Add sendExceptionToClient() and isNativeWebSocket() methods to
BaseWsExceptionFilter to detect the client type and use client.send()
for native WebSocket clients. Update WsExceptionsHandler guard to
allow clients with send() through to the exception filter.

Closes #9056

Pull Request Pull Request #16336: fix(websockets): deliver exception errors to native ws clients

Run Details

2851 of 3557 branches covered (80.15%)

10 of 10 new or added lines in 2 files covered. (100.0%)

64 existing lines in 7 files now uncovered.

7447 of 8296 relevant lines covered (89.77%)

18.47 hits per line