enbility / spine-go / 21826763158

94%

Build Type

push

github

Committed by web-flow

Commit Message

Fix calendar-dependent duration encoding in NewDurationType (#82)

Replace time.Now()-based calendar decomposition with pure arithmetic
using days/hours/minutes/seconds only. The previous implementation used
time.Now() + AddDate() to produce year/month components (P1Y, P1M), but
GetTimeDuration() decoded them via fixed averages (1M ≈ 30.44 days),
causing lossy round-trips that varied by date (e.g. failing in February
when 28 days encoded as P1M decoded back to ~30.44 days).

Since time.Duration is an absolute nanosecond count with no calendar
concept, decomposing into days is the truthful representation and
guarantees exact round-trips regardless of when the code runs.

Fixes https://github.com/enbility/spine-go/issues/81

Run Details

12 of 12 new or added lines in 1 file covered. (100.0%)

17 existing lines in 2 files now uncovered.

5626 of 5993 relevant lines covered (93.88%)

28921.09 hits per line