FlexMeasures / flexmeasures / 21800967156

78%

push

github

CI/agent lessons from PR 1961 (#1964)

* fix: the copilot-setup-steps job requires a specific name

Signed-off-by: F.N. Claessen <felix@seita.nl>

* agents/coordinator: document symmetric fixes anti-pattern

Context:
- Coordinator tracks system-wide patterns and failures
- Session revealed new anti-pattern: symmetric fixes without verification
- Should be documented for future governance oversight

Change:
- Added 'Symmetric fixes without independent verification' pattern
- Documents observation, root cause, and solution
- References updated agent instructions (Test, Review Lead, API)
- Explains why pattern matters for system health

Purpose:
- System-wide awareness of anti-pattern
- Reference for future coordinator reviews
- Verification that agent updates address root cause
- Long-term knowledge capture for agent evolution

* agents/review-lead: add guidance to question symmetric fixes

Context:
- Review Lead orchestrates specialists and synthesizes findings
- Should catch cross-cutting anti-patterns like symmetric fixes
- Session showed need for explicit orchestration guidance

Change:
- Added 'Must Question Symmetric Fixes' section
- Documents what symmetric fixes are and why dangerous
- Provides checklist for identifying and challenging them
- Includes example review comment for specialists
- Integrates with coordination responsibilities

Enables:
- Early detection of symmetric fix patterns in PR reviews
- Coordination between Test and API specialists
- Verification requests using revert-and-re-test pattern
- Minimal changeset enforcement across agents

* agents/api-compatibility: add api change necessity checks

Context:
- API Specialist should minimize unnecessary API changes
- Session showed API change may not have been needed (only test fix)
- Need to verify API changes aren't just test fixes in disguise

Change:
- Added 'API Change Necessity' subsection to Review Checklist
- Documents pattern of unnecessary API fixes
- Provides verification ... (continued)

1611 of 2134 branches covered (75.49%)

Branch coverage included in aggregate %.

11175 of 14315 relevant lines covered (78.06%)

6.24 hits per line